Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Inconsistent durable consumer state after stream peer removal #2904

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

derekcollison
Copy link
Member

When removing a stream peer with an attached durable consumer, the consumer could become inconsistent.

Signed-off-by: Derek Collison [email protected]

/cc @nats-io/core

…nsumer could become inconsistent.

Signed-off-by: Derek Collison <[email protected]>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but a more general concern that is unlikely unfounded.

server/jetstream_cluster.go Show resolved Hide resolved
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit eb1ed55 into main Mar 6, 2022
@derekcollison derekcollison deleted the peer_remove_bad_consumer_state branch March 6, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants