Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some JetStream Asset CRUD events aren't being published #2886

Closed
ColinSullivan1 opened this issue Feb 25, 2022 · 0 comments · Fixed by #2887
Closed

Some JetStream Asset CRUD events aren't being published #2886

ColinSullivan1 opened this issue Feb 25, 2022 · 0 comments · Fixed by #2887

Comments

@ColinSullivan1
Copy link
Member

Defect

A NATS user reported that:

Hello, quick question about Jetstream Advisories. Looking at the Monitoring Jetstream documentation, there is an avisory which you title “Stream CRUD operations”. That suggests all operations on streams (create, update, delete) would fire events. However, we don’t seem to get events for other than CREATED events? The subject you have on that table suggests that as well as it’s $JS.EVENT.ADVISORY.STREAM.CREATED., rather than $JS.EVENT.ADVISORY.STREAM.<STREAM_OPERATION>. . Is this on purpose?

I verified this locally. After discussion on NATS slack, @kozlovic discovered that the stream closes its “internalLoop” responsible to send messages before sending the advisory.

It's possible other events are affected as well.

kozlovic added a commit that referenced this issue Feb 25, 2022
The "deleted" advisory was missing because the stream's send loop
was closed before the advisory was pushed to the queue to be sent.

Added tests, both for single and clustered mode to test all stream
advisories.

Resolves #2886

Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic added a commit that referenced this issue Feb 25, 2022
The "deleted" advisory was missing because the stream's send loop
was closed before the advisory was pushed to the queue to be sent.

Added tests, both for single and clustered mode to test all stream
advisories.

Resolves #2886

Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic added a commit that referenced this issue Mar 5, 2022
The "deleted" advisory was missing because the stream's send loop
was closed before the advisory was pushed to the queue to be sent.

Added tests, both for single and clustered mode to test all stream
advisories.

Resolves #2886

Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic added a commit that referenced this issue Mar 6, 2022
The "deleted" advisory was missing because the stream's send loop
was closed before the advisory was pushed to the queue to be sent.

Added tests, both for single and clustered mode to test all stream
advisories.

Resolves #2886

Signed-off-by: Ivan Kozlovic <[email protected]>
@bruth bruth removed the 🐞 bug label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants