Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from unexpected EOF with API Server #54

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jun 26, 2018

Fixes #53

Signed-off-by: Waldemar Quevedo [email protected]

@wallyqs wallyqs requested a review from ColinSullivan1 June 26, 2018 20:12
@wallyqs wallyqs force-pushed the recover-from-broken-connection branch from 989458e to 466e43e Compare June 26, 2018 20:44
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wallyqs wallyqs merged commit c018ca6 into master Jun 26, 2018
@wallyqs wallyqs deleted the recover-from-broken-connection branch June 26, 2018 21:18
@@ -35,9 +35,10 @@ func pollEvent(decoder *json.Decoder) (*Event, *metav1.Status, error) {
re := &rawEvent{}
err := decoder.Decode(re)
if err != nil {
if err == io.EOF {
if err == io.EOF || err == io.ErrUnexpectedEOF {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here could also be a GoAwayError from http2

received invalid event from API server: fail to decode raw event from apiserver (http2: server sent GOAWAY and closed the connection; LastStreamID=2475, ErrCode=NO_ERROR, debug="") 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants