Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cert used for Routes TLS #44

Merged
merged 6 commits into from
Apr 25, 2018
Merged

Fix cert used for Routes TLS #44

merged 6 commits into from
Apr 25, 2018

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Apr 25, 2018

When enabling TLS for cluster routes, verification was failing since was using the certs the ones for the client port.

@wallyqs wallyqs changed the title Fix cert used for Routes TLS certs Fix cert used for Routes TLS Apr 25, 2018
@ColinSullivan1 ColinSullivan1 self-requested a review April 25, 2018 20:55
ColinSullivan1
ColinSullivan1 approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wallyqs wallyqs merged commit d27c33f into master Apr 25, 2018
@wallyqs wallyqs deleted the routes-tls-bugfix branch April 25, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinSullivan1 ColinSullivan1 ColinSullivan1 approved these changes

Assignees

@ColinSullivan1 ColinSullivan1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallyqs @ColinSullivan1