Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field to include extra config for the server #134

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Mar 1, 2019

Add field to be able to enable debug and trace, as well as to customize max conns/payload and slow consumer deadline.

apiVersion: "nats.io/v1alpha2"
kind: "NatsCluster"
metadata:
  name: "example-nats"
spec:
  size: 3
  version: "1.4.0"

  # Extra configuration for the server.
  natsConfig:
    debug: true
    trace: true

    # Duration within quotes
    write_deadline: "5s" 

    # In bytes, in this case 5MB
    max_payload: 5242880

    max_connections: 1024
    max_subscriptions: 1024
    max_pending: 65536 # In bytes
    disable_logtime: true
    max_control_line: 2048

Signed-off-by: Waldemar Quevedo [email protected]

@wallyqs wallyqs requested a review from ColinSullivan1 March 1, 2019 18:57
Debug bool `json:"debug,omitempty"`
Trace bool `json:"trace,omitempty"`
WriteDeadline string `json:"write_deadline,omitempty"`
MaxConnections int `json:"max_connections,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, maybe add MaxSubscriptions, MaxControlLine, LogTime? Wdyt?

Copy link
Member Author

@wallyqs wallyqs Mar 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, will add too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more extra fields for the limits, thanks for taking a look.

Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR would be a good place to add the additional fields mentioned.

Signed-off-by: Waldemar Quevedo <[email protected]>
@wallyqs wallyqs merged commit 914a8b3 into nats-io:master Mar 1, 2019
@wallyqs wallyqs deleted the server-config branch March 1, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants