Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consumer recreate #190

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix consumer recreate #190

merged 2 commits into from
Jul 2, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jul 2, 2024

closes #167

Signed-off-by: Tomasz Pietrek [email protected]

Jarema added 2 commits July 2, 2024 07:23
If the Consumer was deleted outside of NACK, it should be recreated.
This fixes the behavior by removing generation check, similar to
c6ca1ed

Signed-off-by: Tomasz Pietrek <[email protected]>
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit 6867d25 into main Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a consumer is deleted from the server, NACK does not recreate it
2 participants