Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use cmd when executing node child processes on Windows #124

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Always use cmd when executing node child processes on Windows #124

merged 1 commit into from
Mar 31, 2017

Conversation

petekanev
Copy link
Contributor

Addresses issue #121 by using the cmd on Windows, as is the default without passing the additional shell option when spawning a node child_process.

@petekanev petekanev requested a review from ivanbuhov March 29, 2017 11:29
@ivanbuhov ivanbuhov merged commit 681dfe2 into master Mar 31, 2017
@pkoleva pkoleva deleted the pete/fix-use-cmd-win branch May 18, 2017 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanbuhov ivanbuhov Awaiting requested review from ivanbuhov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petekanev @ivanbuhov