Fold in client-level fixes from tomlongo/nationbuilder-ios #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring included. References tomlongo/nationbuilder-ios@da30716: Added some public methods for generating the authentication URL and setting the credentials in order to allow the use of a Web View for oAuth rather than the standard loadURL. It’s now possible to fetch the tokens from your own web view, then set them using the setCredentialWithAccessToken:tokenType: method.
Different approach to fix the same issue. References tomlongo/nationbuilder-ios@4a99727: In some cases, baseURLComponents was missing the access_token parameter even though auth was successful. Changed the way this is lazy loaded to ensure the api key is always set.
References tomlongo/nationbuilder-ios@621df85: Added check for NSNull type in pagination which was causing crashes in some cases
hlfcoding
added a commit
that referenced
this pull request
Mar 3, 2016
Fold in client-level fixes from tomlongo/nationbuilder-ios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added.