Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: move ng dependencies and rxjs dependency in the root of the project #361

Closed
SuperITMan opened this issue May 8, 2018 · 0 comments · Fixed by #363
Closed

all: move ng dependencies and rxjs dependency in the root of the project #361

SuperITMan opened this issue May 8, 2018 · 0 comments · Fixed by #363
Labels
comp: stark-all To apply for all Stark modules must type: refactor

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

In stark-ui, stark-core, ... we have devDependencies for @angular/* and for rxjs. (those packages have to be installed by the application itself)

Expected behavior

Instead of installing multiple times @angular deps in each package, we should install them in the ROOT of project and add paths to them in every package.

What is the motivation / use case for changing the behavior?

Improving the project

SuperITMan referenced this issue in SuperITMan/stark May 8, 2018
…build process. Rename tsconfig

Move ng dependencies and rxjs dep into the ROOT to avoid install of those shared in multiple
packages.
Rename tsconfig inside packages to tsconfig-build and remove root tsconfig.json file to
make IntelliJ working correctly

ISSUES CLOSED: #361 #362
@dsebastien dsebastien changed the title Move ng dependencies and rxjs dependency in the root of the project all: move ng dependencies and rxjs dependency in the root of the project May 8, 2018
@dsebastien dsebastien added this to the 10.0.0-alpha.3 milestone May 8, 2018
@dsebastien dsebastien added comp: stark-all To apply for all Stark modules type: refactor must labels May 8, 2018
SuperITMan referenced this issue in SuperITMan/stark May 8, 2018
…build process. Rename tsconfig

Move ng dependencies and rxjs dep into the ROOT to avoid install of those shared in multiple
packages.
Rename tsconfig inside packages to tsconfig-build and remove root tsconfig.json file to
make IntelliJ working correctly

ISSUES CLOSED: #361, #362
SuperITMan referenced this issue in SuperITMan/stark May 8, 2018
…build process. Rename tsconfig

Move ng dependencies and rxjs dep into the ROOT to avoid install of those shared in multiple
packages.
Rename tsconfig inside packages to tsconfig-build and remove root tsconfig.json file to
make IntelliJ working correctly

ISSUES CLOSED: #361, #362
SuperITMan referenced this issue in SuperITMan/stark May 8, 2018
…build process. Rename tsconfig

Move ng dependencies and rxjs dep into the ROOT to avoid install of those shared in multiple
packages.
Rename tsconfig inside packages to tsconfig-build and remove root tsconfig.json file to
make IntelliJ working correctly

ISSUES CLOSED: #361, #362
SuperITMan referenced this issue in SuperITMan/stark May 8, 2018
…build process. Rename tsconfig

Move ng dependencies and rxjs dep into the ROOT to avoid install of those shared in multiple
packages.
Rename tsconfig inside packages to tsconfig-build and remove root tsconfig.json file to
make IntelliJ working correctly

ISSUES CLOSED: #361, #362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: stark-all To apply for all Stark modules must type: refactor
Projects
None yet
2 participants