-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build-main): move ng dependencies to ROOT of Stark. Fix issue in build process. Rename tsconfig #363
fix(build-main): move ng dependencies to ROOT of Stark. Fix issue in build process. Rename tsconfig #363
Conversation
569028f
to
98d294c
Compare
Apparently, there is an issue with tslint. I'll fix that now :) |
98d294c
to
c02254b
Compare
packages/stark-core/package.json
Outdated
@@ -64,17 +56,18 @@ | |||
"@angular/compiler-cli": "5.x", | |||
"@angular/core": "5.x", | |||
"@angular/platform-browser": "5.x", | |||
"@angular/platform-browser-dynamic": "5.x" | |||
"@angular/platform-browser-dynamic": "5.x", | |||
"rxjs": "5.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
angular/router is also needed in Stark Core, could you please add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I forgot this. It's added now
packages/stark-core/package.json
Outdated
@@ -64,17 +56,18 @@ | |||
"@angular/compiler-cli": "5.x", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we need the angular/compiler-cli in Stark Core? and angular/compiler as well?
Aren't they part of Stark Build instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's needed. Currently, they are part of the stark-build and stark-core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, we should remove them unless they are really needed. So if you remove them and everything works just fine...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure, because the deps will be available in the root :)
But ok, I'll remove those peerDeps from stark-core
@@ -1,11 +0,0 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should write some docs about the structure of our tsconfig files: #364
c02254b
to
41a998b
Compare
41a998b
to
c7fecdb
Compare
Move ng dependencies and rxjs dep into the ROOT to avoid install of those shared in multiple
packages.
Rename tsconfig inside packages to tsconfig-build and remove root tsconfig.json file to
make IntelliJ working correctly
ISSUES CLOSED: #361, #362
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #361, #362
What is the new behavior?
Fix build process + Avoid repetition of dependencies in the project.
Does this PR introduce a breaking change?
Other information