Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exporting of character names as comment column in CSV #323

Closed
IntangibleMatter opened this issue Oct 17, 2023 · 8 comments · Fixed by #448
Closed

Add exporting of character names as comment column in CSV #323

IntangibleMatter opened this issue Oct 17, 2023 · 8 comments · Fixed by #448
Assignees
Labels
enhancement New feature or request

Comments

@IntangibleMatter
Copy link

Is your feature request related to a problem? Please describe.
When exporting for translation, it can be very useful for translators to know what character is saying a line. This helps them follow conversations better.

Describe the solution you'd like
Godot supports having ignored columns in translation CSVs by prefixing them with an underscore, like so

key,en,_character
01,Hey,John
02,Hey!,Jade
03,Woah! wild. Same sentence.,Jade

It would be beneficial for reading and writing CSVs for translations if the character was exported as a data column. as this would mean that people reading CSV files would have a better idea of who's saying what.
For additional ease of use, you could even add columns for what file/label a thing is said in. All of this would have no consequence on the dialogue files itself, but it would massively improve readability.

Describe alternatives you've considered
The only alternative is to add these manually, though you may not remember which character is saying "yeah"

@IntangibleMatter IntangibleMatter added the enhancement New feature or request label Oct 17, 2023
@nathanhoad
Copy link
Owner

Is that documented somewhere? I started implementing this but it seems Godot treats those columns as invalid locales and generates extra translations files anyway.

@IntangibleMatter
Copy link
Author

I remember finding it on a forum somewhere... When I did it myself for another project I know that Godot didn't generate files for lines that start with an underscore. Let me test.

@IntangibleMatter
Copy link
Author

Okay, yeah, it generates a translation file without a locale. I think I found this on an old forum or something.

@IntangibleMatter
Copy link
Author

Created an issue. godotengine/godot#83573

@IntangibleMatter
Copy link
Author

This should be easily doable in Godot 4.2, as godotengine/godot#83600 was just merged, which means that columns deemed 'invalid' will be ignored, allowing columns which are intended for comments to start with an _ or -, and have no file generated for that column.

@jsjtxietian
Copy link

I opened a follow up pr for this godotengine/godot#84569, now csv column start's with _ will not trigger warning anymore.

@IntangibleMatter
Copy link
Author

Commenting again to check the status of this now that we're in 4.2

@nathanhoad nathanhoad changed the title Add exporting of character names as comment column in SCV Add exporting of character names as comment column in CSV Jan 12, 2024
@jkulawik
Copy link

jkulawik commented Jan 17, 2024

A simple way of bypassing this issue would be to add the character names to the translation IDs.

E.g. John:0a7cb0f71a532d9b1f

Might need processing if these contain weird signs, and also should be toggleable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants