You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the solution you'd like
Ideally, if poorman is desired to be swappable with dplyr, it would use the same class name for grouped data frames, in order that S3 methods looking for grouped_df don't need to be swapped to grouped_data. Probably seems like a small thing, but being unfamiliar with S3 classes, it took me a while to figure out why tests were failing for a grouped case and how to fix it.
Suggest code changes
I imagine it'd be a find and replace for grouped_data to grouped_df
Describe the solution you'd like
Ideally, if poorman is desired to be swappable with dplyr, it would use the same class name for grouped data frames, in order that S3 methods looking for
grouped_df
don't need to be swapped togrouped_data
. Probably seems like a small thing, but being unfamiliar with S3 classes, it took me a while to figure out why tests were failing for a grouped case and how to fix it.Suggest code changes
I imagine it'd be a find and replace for
grouped_data
togrouped_df
Additional context
Example change here.
The text was updated successfully, but these errors were encountered: