Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped Data Frames Share a Class Name with Their Dplyr Equivalent #70

Closed
alex-gable opened this issue Jan 6, 2021 · 0 comments
Closed
Labels
feature request New feature or request
Milestone

Comments

@alex-gable
Copy link

Describe the solution you'd like
Ideally, if poorman is desired to be swappable with dplyr, it would use the same class name for grouped data frames, in order that S3 methods looking for grouped_df don't need to be swapped to grouped_data. Probably seems like a small thing, but being unfamiliar with S3 classes, it took me a while to figure out why tests were failing for a grouped case and how to fix it.

Suggest code changes
I imagine it'd be a find and replace for grouped_data to grouped_df

Additional context
Example change here.

@alex-gable alex-gable added the feature request New feature or request label Jan 6, 2021
@nathaneastwood nathaneastwood added this to the 0.2.5 milestone Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants