-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cocoapods support, changed project structure and added all pods requirements #82
Conversation
Thanks for your work, we have plans for cocoapods support and more changes in the works https://github.com/fhsjaagshs/FHSTwitterEngine/tree/development but no eta.. |
Yes, I've noticed it in the readme that is why I did it, anyway the changes didn't modify anything of the source code , only the project structure, so it should merge smoothly with development or master branch. Let me know if you need more help with it |
Fixed bug that cause Swift demo app to crash on launch
@salah-ghanim can you resolve the conflicts? |
Closing for now. Let me know if you would like to revisit this. |
hey @dkhamsing sorry that I didn't respond earlier. I've been meaning to fix the conflict for a while. Its just been a while since I did these changes, and the conflict size is quit big. Anyway, I can get them done this weekend. |
Oh cool, will reopen |
Once you merge with master you can modify the repo's url inside the podspec file to point to your rep so
should become
PS also double check the tags/versions |
Will take a look thank you |
Cocoapods support, changed project structure and added all pods requirements
Notes
|
Restructured the project to fit default cocoapods default structure for libraries.
Kept the current example in sample folder.
Moved source code to src directory
Added project dependancies, license, and all necessary details to the podspec file