Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods support, changed project structure and added all pods requirements #82

Merged
merged 14 commits into from
Dec 7, 2015
Merged

Conversation

salah-ghanim
Copy link
Contributor

Restructured the project to fit default cocoapods default structure for libraries.

Kept the current example in sample folder.

Moved source code to src directory

Added project dependancies, license, and all necessary details to the podspec file

@dkhamsing
Copy link
Collaborator

Thanks for your work, we have plans for cocoapods support and more changes in the works https://github.com/fhsjaagshs/FHSTwitterEngine/tree/development but no eta..

@salah-ghanim
Copy link
Contributor Author

Yes, I've noticed it in the readme that is why I did it, anyway the changes didn't modify anything of the source code , only the project structure, so it should merge smoothly with development or master branch.

Let me know if you need more help with it

@dkhamsing
Copy link
Collaborator

@salah-ghanim can you resolve the conflicts?

@dkhamsing
Copy link
Collaborator

Closing for now. Let me know if you would like to revisit this.
😅

@dkhamsing dkhamsing closed this Dec 1, 2015
@salah-ghanim
Copy link
Contributor Author

hey @dkhamsing sorry that I didn't respond earlier. I've been meaning to fix the conflict for a while.

Its just been a while since I did these changes, and the conflict size is quit big.

Anyway, I can get them done this weekend.

@dkhamsing
Copy link
Collaborator

Oh cool, will reopen

@dkhamsing dkhamsing reopened this Dec 1, 2015
@salah-ghanim
Copy link
Contributor Author

@dkhamsing

Once you merge with master you can modify the repo's url inside the podspec file to point to your rep

so

  s.source = { :git => "https://github.com/salah-ghanim/FHSTwitterEngine.git", :tag => s.version.to_s }

should become

  s.source = { :git => "https://github.com/fhsjaagshs/FHSTwitterEngine.git", :tag => s.version.to_s }

PS also double check the tags/versions

@dkhamsing
Copy link
Collaborator

Will take a look thank you

dkhamsing added a commit that referenced this pull request Dec 7, 2015
Cocoapods support, changed project structure and added all pods requirements
@dkhamsing dkhamsing merged commit 5576e0b into natesymer:master Dec 7, 2015
@dkhamsing
Copy link
Collaborator

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants