fix: incorrectly removing initial characters due to trailing whitespace #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 956acef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Adammatthiesen
previously approved these changes
Apr 26, 2024
There was a problem hiding this comment.
This is looking great! Thank you @chelkyl, this patch will be much appreciated within the entire astro community! let me get Nate to double check and hopefully we will have it integrated here in the next week or so!
|
Sounds good! The force push was to correct the changeset reference from |
Adammatthiesen
approved these changes
Apr 30, 2024
natemoo-re
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #27 by updating the internal
getIndentfunction to usetrimStartinstead oftrimso that it only counts whitespace at the beginning.See internal
test-issue27from the playground.