feat: pass props to custom resolver #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 73cb90e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @natemoo-re, please take a look when you have time. |
natemoo-re
approved these changes
Jul 19, 2022
|
Thanks for adding a changeset. Will make sure to add next time ;). Is there anything else needed from my side, or you'll merge? |
|
@natemoo-re, can you merge this please 🙏 ? |
|
@natemoo-re Can we have this released please? 🙏 |
Merged
manuelmeister
pushed a commit
to manuelmeister/astro-iconify
that referenced
this pull request
Nov 12, 2022
Co-authored-by: Nate Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR passes
Iconproperties down to custom resolver in order to allow building custom asset URLs that depend not only on icon name, but also size.