Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret null as true #397

Merged
merged 2 commits into from
Nov 7, 2020
Merged

Interpret null as true #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83e237c
Interpret null as true
TheConstructor Sep 25, 2020
1864a38
Added tests
TheConstructor Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CommandLineUtils/Internal/ValueParsers/StockValueParsers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ internal static class StockValueParsers
switch (value)
{
case null:
return default;
return true;
case "T":
case "t":
return true;
Expand Down
48 changes: 46 additions & 2 deletions test/CommandLineUtils.Tests/ValueParserProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Reflection;
using Xunit;

namespace McMaster.Extensions.CommandLineUtils.Tests
{
using System.Reflection;

public class ValueParserProviderTests
{
public enum Color
Expand Down Expand Up @@ -45,6 +44,12 @@ private class Program
[Option("--bool-opt", CommandOptionType.SingleValue)]
public bool? BoolOpt { get; }

[Option("--bool-with-optional-value", CommandOptionType.SingleOrNoValue)]
public bool BoolWithOptionalValue { get; }

[Option("--bool-opt-with-optional-value", CommandOptionType.SingleOrNoValue)]
public (bool, bool?) BoolOptWithOptionalValue { get; }

[Option("--int32-opt")]
public int? Int32Opt { get; }

Expand Down Expand Up @@ -300,6 +305,45 @@ public void ParsesNullableBool(string arg, bool? result)
Assert.Equal(result, parsed.BoolOpt);
}

[Theory]
[InlineData("true", true)]
[InlineData("True", true)]
[InlineData("False", false)]
[InlineData("false", false)]
public void ParsesBoolWithOptionalValue(string arg, bool result)
{
var parsed = CommandLineParser.ParseArgs<Program>($"--bool-with-optional-value:{arg}");
Assert.Equal(result, parsed.BoolWithOptionalValue);
}

[Fact]
public void ParsesBoolWithoutOptionalValue()
{
var parsed = CommandLineParser.ParseArgs<Program>("--bool-with-optional-value");
Assert.True(parsed.BoolWithOptionalValue);
}

[Theory]
[InlineData("", null)]
[InlineData("true", true)]
[InlineData("True", true)]
[InlineData("False", false)]
[InlineData("false", false)]
public void ParsesNullableBoolWithOptionalValue(string arg, bool? result)
{
var parsed = CommandLineParser.ParseArgs<Program>($"--bool-opt-with-optional-value:{arg}");
Assert.True(parsed.BoolOptWithOptionalValue.Item1);
Assert.Equal(result, parsed.BoolOptWithOptionalValue.Item2);
}

[Fact]
public void ParsesNullableBoolWithoutOptionalValue()
{
var parsed = CommandLineParser.ParseArgs<Program>("--bool-opt-with-optional-value");
Assert.True(parsed.BoolOptWithOptionalValue.Item1);
Assert.Null(parsed.BoolOptWithOptionalValue.Item2);
}

[Theory]
[InlineData("4294967295", uint.MaxValue)]
[InlineData("1", 1)]
Expand Down