-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show allowed values in help text for Nullable/ValueTuple<bool,T> option/argument #390
Show allowed values in help text for Nullable/ValueTuple<bool,T> option/argument #390
Conversation
@natemcmaster |
I ask because I have to specify
rather than
CommandLineUtils/test/CommandLineUtils.Tests/DefaultHelpTextGeneratorTests.cs Lines 208 to 209 in b10e802
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! There is a merge conflict now, though, with your other PR. Can you resolved and update?
re: your question
Let's open a separate issue for this. We need to think through backwards compatibility of this change given that the current behavior is SingleValue. I think changing to SingleOrNoValue could break some users unless we also improve the parser to support |
Conflicts are resolved. |
Thanks @scott-xu ! |
Fix #388