Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch Ctrl+C only if handler supports cancellation #305

Closed
wants to merge 2 commits into from
Closed

Catch Ctrl+C only if handler supports cancellation #305

wants to merge 2 commits into from

Conversation

thomaslevesque
Copy link
Contributor

Fixes #302

@natemcmaster
Copy link
Owner

Thanks again for proposing this fix, @thomaslevesque. I'm sorry this sat stale for so long. The original issue you were trying to address with this PR was solved in 3c2a490 instead.

Thanks for the contribution. I hope you'll continue to propose more fixes :)

Nate

@thomaslevesque thomaslevesque deleted the ctrl-c-handling branch March 9, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemcmaster natemcmaster Awaiting requested review from natemcmaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ctrl+C doesn't kill the process
2 participants
@thomaslevesque @natemcmaster