Skip to content

Commit

Permalink
Drop thumbs up reaction as pull request approval method
Browse files Browse the repository at this point in the history
Also clarify that a -1 is a veto for normal pull requests as well,
as mentionied in the "Vetoes" subsection below.
  • Loading branch information
nsoranzo committed Nov 25, 2024
1 parent 7a68911 commit 916890f
Showing 1 changed file with 11 additions and 16 deletions.
27 changes: 11 additions & 16 deletions doc/source/project/organization.rst
Original file line number Diff line number Diff line change
Expand Up @@ -127,26 +127,21 @@ Everyone is encouraged to express opinions and issue non-binding votes on pull
requests, but only members of the *committers* group may issue binding votes
on pull requests.

Votes on pull requests should take the form of +1, 0, -1, and fractions as
outlined by the `Apache Software Foundation voting rules`_. The following are
equivalent to a +1 vote:

- a `thumbs up reaction <https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/>`__
on the pull request description;
- approving the pull request when submitting a
`review <https://help.github.com/articles/reviewing-proposed-changes-in-a-pull-request/>`__.

The latter is the preferred method because it is integrated in GitHub, it allows
tracking the moment when the review was submitted, and it sends a notification
to subscribers.
Votes on pull requests should be expressed in pull request comments in the form
of +1, 0, -1, and fractions as outlined by the
`Apache Software Foundation voting rules`_.
Approving a pull request when submitting a
`review <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request>`__
is equivalent to a +1 vote.
The latter is the preferred method because it is integrated in GitHub.

Pull requests changing or clarifying the *Procedure Documents* (listed above):

- Must be made to the ``dev`` branch of this repository.
- Must remain open for at least 192 hours (unless every qualified *committer* has
voted).
- Require binding *+1* votes from at least 25% of qualified *committers* with no
*-1* binding votes.
- Require binding *+1* votes from at least 25% of qualified *committers*, with
no *-1* binding votes.
- Should be titled with the prefix *[PROCEDURES]* and tagged with
the *procedures* tag in Github.
- Should not be modified once open. If changes are needed, the pull request
Expand All @@ -160,8 +155,8 @@ Pull requests changing or clarifying the *Procedure Documents* (listed above):
subject to the 192 hour nor 25% rule, and can be merged by any other member.

Any other pull request requires at least 1 *+1* binding vote from someone other
than the author of the pull request. A member of the *committers* group merging
a pull request is considered an implicit +1.
than the author of the pull request, with no *-1* binding votes. A member of the
*committers* group merging a pull request is considered an implicit +1.

Pull requests modifying frozen and tagged release branches should be restricted
to bug fixes. As an exception, pull requests which only add new datatypes can
Expand Down

0 comments on commit 916890f

Please sign in to comment.