Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on 3.12, drop support for 3.7 #96

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

phargogh
Copy link
Member

No changes needed, but I did add a pyproject.toml to the project to update for the latest build standards.

Fixes #95

Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @phargogh just one minor thing I noticed in setup.py

setup.py Outdated Show resolved Hide resolved
@phargogh
Copy link
Member Author

Whoops, thanks for catching that @dcdenu4 !

@phargogh phargogh requested a review from dcdenu4 October 27, 2023 19:04
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @phargogh , something funky happened in pyproject.toml, 3.12 was swapped back to 3.11.

pyproject.toml Outdated Show resolved Hide resolved
@phargogh
Copy link
Member Author

Weird, let's try this again!

@phargogh phargogh requested a review from dcdenu4 October 27, 2023 19:08
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@dcdenu4 dcdenu4 merged commit aa7d41c into natcap:main Oct 27, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support python 3.12
2 participants