Fix layering bug #88
Merged
Fix layering bug #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was brought about after testing sorting but wasn't necessarily caused by sorting. Basically the bug was not being able to reliably redraw the z-index order when changing scale, changing basemaps, and changing visibility. This commit is a first pass at fixing that. It currently seems to function as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was brought about after testing sorting but wasn't necessarily caused by sorting. Basically the bug was not being able to reliably redraw the z-index order when changing scale, changing basemaps, and changing visibility. This commit is a first pass at fixing that. It currently seems to function as expected.
The big thing I was missing was in how
map.moveLayer(layerId, beforeId)was behaving. I was moving the least visible layers first "before" more visible layers. However, those more "visible" layers could be anywhere in the layering order, causing unexpected behavior. Thus, moving / setting the most visible layers first provided a stable way to get expected layering order.