Fix OrientationHelper #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @aartikov ! And thank you for writing tests. |
natario1
approved these changes
Oct 19, 2018
derohimat
added a commit
to derohimat/CameraView
that referenced
this pull request
Oct 19, 2018
Use cached orientation in OrientationHelper (natario1#290)
1 task
|
I have this "flat" issue too. also my app is locked in landscape.. and the pictures taken when the phone is in portrait are not rotated correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to use a previous orientation value when a sensor returns ORIENTATION_UNKNOWN.
It will allow to make landscape photos when a device is almost parallel to the ground plane.