Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preview size selection #133

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

YeungKC
Copy link
Contributor

@YeungKC YeungKC commented Jan 5, 2018

matchRatio may get unexpected size when implementation of getSupportedPreviewSizes() decides to return values in a non-descending order.

matchRatio may get unexpected size when implementation of getSupportedPreviewSizes() decides to return values in a non-descending order.
@codecov
Copy link

codecov bot commented Jan 5, 2018

Codecov Report

Merging #133 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted Files Coverage Δ Complexity Δ
...com/otaliastudios/cameraview/CameraController.java 25.8% <0%> (-0.2%) 23 <0> (ø)
...otaliastudios/cameraview/TextureCameraPreview.java 43.4% <0%> (-26.1%) 4% <0%> (-1%)

@natario1
Copy link
Owner

natario1 commented Jan 5, 2018

I see your point. Thanks for fixing this!

@natario1 natario1 merged commit 2dd1912 into natario1:master Jan 5, 2018
@YeungKC
Copy link
Contributor Author

YeungKC commented Jan 5, 2018

Are you think need how about provide control the actual preview size?
Sometimes need the feature.

My English isn't very good, please don't mind.

@natario1
Copy link
Owner

natario1 commented Jan 5, 2018

I'll be away from keyboard for two months. If you really need this, you can open a PR. Take a look at the commit history, there are commits called Bump version.

You should replicate the same for a new version. Bump the version in Gradle, in the README file, and write a proper change log in CHANGELOG file. If you do this we can release to 1.4.2.

@YeungKC
Copy link
Contributor Author

YeungKC commented Jan 5, 2018

I this paragraph of time work is very busy, but I will try.

@ychescale9
Copy link

I'm also interested in being able to configure the preview size for frame processing. @YeungKC will you be working on this? if not I'd be happy to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants