Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the offset computation for front cameras #112

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Change the offset computation for front cameras #112

merged 1 commit into from
Nov 22, 2017

Conversation

natario1
Copy link
Owner

@natario1 natario1 commented Nov 21, 2017 •
edited
Loading

This should fix #108 and possibly not break anything else.

The old formula was giving correct results for sensorOffset = 90 and sensorOffset = 270, but not in the other cases (0 and 180). That might be the reason why no-one has been reporting it.

@natario1 natario1 mentioned this pull request Nov 21, 2017
Closed
3 tasks
@codecov
Copy link

codecov bot commented Nov 21, 2017 •
edited
Loading

Codecov Report

Merging #112 into master will decrease coverage by <.1%.
The diff coverage is 0%.

Impacted Files Coverage Δ Complexity Δ
...com/otaliastudios/cameraview/CameraController.java 25.6% <0%> (ø) 23 <0> (ø) ⬇️
...otaliastudios/cameraview/TextureCameraPreview.java 65.2% <0%> (-4.4%) 4% <0%> (-1%)

@natario1 natario1 merged commit ced6058 into master Nov 22, 2017
@natario1 natario1 deleted the fix-front-offset branch November 22, 2017 10:12
@lancewoo lancewoo mentioned this pull request Dec 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rotated preview on front camera
1 participant
@natario1