Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize types with ruff check --select=FA,UP #247

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 24, 2024

Fixes #246

https://docs.astral.sh/ruff/rules/#flake8-future-annotations-fa
Steps:

  1. Modify pyproject.toml to use the new ruff config settings and allow FA,UP fixes
  2. Run ruff check --select=FA to see which files would benefit from from __future__ import annotations
  3. Run ruff check --select=FA,UP --fix --unsafe-fixes
Found 470 errors (470 fixed, 0 remaining).

@cclauss cclauss changed the title Modernize types with All checks passed! Modernize types with ruff check --select=FA,UP Sep 24, 2024
@cclauss cclauss force-pushed the modernize-Python-type-hints branch from 6ff4efc to fea1336 Compare September 24, 2024 21:57
@cclauss
Copy link
Contributor Author

cclauss commented Sep 24, 2024

This is probably too far from the current codebase. Please don't hesitate to close this if it is too early. These kinds of PRs are relatively easy to regenerate when the project is ready for it.

@cclauss cclauss closed this Sep 26, 2024
@cclauss cclauss deleted the modernize-Python-type-hints branch September 26, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade ruff?
1 participant