Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands are echoed without quotation marks in the log #169

Closed
dbohdan opened this issue Sep 27, 2023 · 3 comments
Closed

Commands are echoed without quotation marks in the log #169

dbohdan opened this issue Sep 27, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@dbohdan
Copy link
Contributor

dbohdan commented Sep 27, 2023

When you define a command task with parts in quotes, the command shows in the log without the quotes. This makes it harder to understand the log and also prevents you from copying and pasting the command into your shell.

For example, for the task

foo = "echo 'Hello, world!'"

the output from Poe the Poet 0.23.0 is

> poe foo
Poe => echo Hello, world!
Hello, world!

But as a user, I expect output like

> poe foo
Poe => echo 'Hello, world!'
Hello, world!

I don't think the quotation marks must necessarily be those in the literal text. What I have done in similar situations is join the command with shlex.join before logging it.

@nat-n
Copy link
Owner

nat-n commented Sep 28, 2023

hi @dbohdan, thanks for the feedback.

I think your suggestion makes sense, I'll try get it into the next release.

@nat-n
Copy link
Owner

nat-n commented Sep 30, 2023

This enhancement is now available in v0.24.0 🚀

@nat-n nat-n closed this as completed Sep 30, 2023
@dbohdan
Copy link
Contributor Author

dbohdan commented Sep 30, 2023

That was quick! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants