cast min max values correctly

nasdf · Sep 27, 2024 · db85fa3 · db85fa3
1 parent 63f062c
commit db85fa3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/internal/planner/max.go b/internal/planner/max.go
@@ -221,13 +221,11 @@ func (n *maxNode) Next() (bool, error) {
 		max = math.Max(max, collectionMax)
 	}
 
-	var typedMax any
 	if n.isFloat {
-		typedMax = max
+		n.currentValue.Fields[n.virtualFieldIndex] = float64(max)
 	} else {
-		typedMax = int64(max)
+		n.currentValue.Fields[n.virtualFieldIndex] = int64(max)
 	}
-	n.currentValue.Fields[n.virtualFieldIndex] = typedMax
 
 	return true, nil
 }
diff --git a/internal/planner/min.go b/internal/planner/min.go
@@ -221,13 +221,11 @@ func (n *minNode) Next() (bool, error) {
 		min = math.Min(min, collectionMin)
 	}
 
-	var typedMin any
 	if n.isFloat {
-		typedMin = min
+		n.currentValue.Fields[n.virtualFieldIndex] = float64(min)
 	} else {
-		typedMin = int64(min)
+		n.currentValue.Fields[n.virtualFieldIndex] = int64(min)
 	}
-	n.currentValue.Fields[n.virtualFieldIndex] = typedMin
 
 	return true, nil
 }
diff --git a/tests/integration/query/simple/with_group_max_test.go b/tests/integration/query/simple/with_group_max_test.go
@@ -291,7 +291,7 @@ func TestQuerySimple_WithGroupByStringWithoutRenderedGroupAndChildEmptyFloatMax_
 						},
 						{
 							"Name": "Alice",
-							"_max": -math.MaxFloat64,
+							"_max": float64(-math.MaxFloat64),
 						},
 					},
 				},

diff --git a/tests/integration/query/simple/with_group_min_test.go b/tests/integration/query/simple/with_group_min_test.go
@@ -291,7 +291,7 @@ func TestQuerySimple_WithGroupByStringWithoutRenderedGroupAndChildEmptyFloatMin_
 						},
 						{
 							"Name": "Alice",
-							"_min": math.MaxFloat64,
+							"_min": float64(math.MaxFloat64),
 						},
 					},
 				},
-Original file line number
+Diff line change
@@ Expand Up @@
     						},
     						{
     							"Name": "Alice",
-    							"_max": -math.MaxFloat64,
+    							"_max": float64(-math.MaxFloat64),
     						},
     					},
     				},
@@ Expand Down @@