Fix #36, Use OS_MAX_QUEUE_DEPTH rather than 64. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
This should configure the maximum depth supported by OSAL, rather than a hard coded 64. Moved both pipe depth configurations to a macro in the header file.
jphickey
force-pushed
the
fix-36-queue-depth
branch
from
1886aaa to
76a0d31
Compare
skliper
approved these changes
May 7, 2020
skliper
added
CCB-20200513
and removed
CCB:Ready
|
CCB 20200513 - Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Configure the maximum depth supported by OSAL, rather than a hard coded 64.
Fixes #36
Testing performed
Build with default config. Confirm normal operation of TO_LAB on system with max queue depth set to 50.
Expected behavior changes
None, except on systems where supported queue depth is less than 64.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.