Fix #55 #56, Remove action branch restrictions, add duplicate checks, fix format check job name, remove --quiet #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable format-check and static-analysis workflows to run on push to arbitrary branches. Enable CodeQL workflow to run on pull requests targeting arbitrary branches.
|
Does the duplicate check job work without |
|
@ArielSAdamsNASA Doesn't look like it, good catch! Fixing now... |
skliper
force-pushed
the
fix56-cppcheck_rm_quiet
branch
from
2be5d19 to
f8f32a0
Compare
ArielSAdamsNASA
approved these changes
Oct 22, 2021
|
OBE, #57 is a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
--quietflag from cppcheck #56Remove action branch restrictions, add duplicate checks, fix format check job name, remove --quiet
Testing performed
CI
Expected behavior changes
System(s) tested on
CI
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC
@astrogeco