Recommended lgtm issues

[avan989]

Is your feature request related to a problem? Please describe.
Recommended issue from lgtm:
cfe_ts_crc.c:

switch(TypeCRC)
--
114 | {
115 | /*       case CFE_ES_CRC_32:                                                    */
116 | /*            CFE_ES_WriteToSysLog("CFE ES Calculate CRC32 not Implemented\n"); */
117 | /*            break;                                                            */
118 |  
119 | case CFE_ES_CRC_16:
120 | Crc    =  (int16 )( 0xFFFF & InputCRC );
121 | BufPtr = (uint8 *)DataPtr;
122 |  
123 | for ( i = 0 ; i < DataLength ; i++,  BufPtr++)
124 | {
125 | Index = ( ( Crc ^ *BufPtr) & 0x00FF);
126 | Crc = ( (Crc >> 8 ) & 0x00FF) ^ CrcTable[Index];
127 | }
128 | break;
129 |  
130 | /*       case CFE_ES_CRC_8:                                                    */
131 | /*            CFE_ES_WriteToSysLog("CFE ES Calculate CRC8 not Implemented\n"); */
132 | /*            break;                                                           */
133 |  
134 | default:
135 | break;
136 | }
  | This switch statement should either handle more cases, or be rewritten as an if statement.


{
--
115 | /*       case CFE_ES_CRC_32:                                                    */
116 | /*            CFE_ES_WriteToSysLog("CFE ES Calculate CRC32 not Implemented\n"); */
  | This comment appears to contain commented-out code
117 | /*            break;                                                            */
  | This comment appears to contain commented-out code



/*       case CFE_ES_CRC_8:                                                    */
--
131 | /*            CFE_ES_WriteToSysLog("CFE ES Calculate CRC8 not Implemented\n"); */
  | This comment appears to contain commented-out code
132 | /*            break;                                                           */
  | This comment appears to contain commented-out code

Requester Info
Anh Van, NASA Goddard

[skliper]

Code is messy to begin with, suggest just simplifying to only do CRC_16. If other options are added in the future update the code at that time (keep simple for now).