Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate 2020-07-29 #28

Merged
merged 5 commits into from
Aug 5, 2020
Merged

Integration Candidate 2020-07-29 #28

merged 5 commits into from
Aug 5, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Aug 4, 2020

Describe the contribution
Fix #26
Close #25

Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/119/checks

Expected behavior changes

PR #27 - Install unit test as part of cmake recipe. Sample lib test runner now shows up in expected install directory

PR #29 - Add development build number and baseline to version reporting

System(s) tested on
Ubuntu

Additional context
Part of nasa/cFS#119

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC
Gerardo E. Cruz-Ortiz, NASA-GSFC

@astrogeco astrogeco marked this pull request as draft August 4, 2020 17:38
Gerardo E. Cruz-Ortiz and others added 2 commits August 5, 2020 10:23
Add new build macros for baseline and build number.
Add string helper macros.
Add version strings.
Close #25, Add build number and baseline to version file
@astrogeco astrogeco marked this pull request as ready for review August 5, 2020 21:32
Format "development build" string portion as ALL CAPS for readability
@astrogeco astrogeco force-pushed the integration-candidate branch from 5a79f1b to fd5058c Compare August 5, 2020 21:33
@astrogeco astrogeco merged commit ce70d3d into main Aug 5, 2020
@skliper skliper added this to the 1.2.0 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test doesn't get installed Add Build name and Build number to version.h
2 participants