Fix #697, use VERSION_LESS instead of VERSION_GREATER_EQUAL #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recommend fast track because the main branch is broken. |
skliper
approved these changes
Dec 21, 2020
|
Changed my mind on this, I came up with a different workaround that lets vxworks 6.9 use the posix dir implementation. Probably should have done that first... |
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#693, Utilize UT macros in sb_UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The VERSION_GREATER/LESS_EQUAL comparisons wer not introduced until CMake 3.7. However, the basic VERSION_GREATER/LESS (no equal) comparison is much older, and 2.8.12 has no complaint about it. So use VERSION_LESS and invert the condition.
Fixes #697
Testing performed
Build for VxWorks 6.9 on RHEL 7.9
Expected behavior changes
Makefiles are generated and build succeeds.
System(s) tested on
VxWorks 6.9 using RHEL 7.9 host
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.