Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #526, scrub OSAL stubs #527

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Ensure that:

  1. All stub routines register their arguments in the context, so that the values will be available to hook functions.
  2. The argument names used in stubs match the name in the prototype/documentation so the value can be retrieved by name.

Fixes #526

Testing performed
Build and execute all unit tests
Sanity check CFE

Expected behavior changes
No impact to behavior. This just makes it so hook functions can access the full set of parameters for all stub APIs.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

astrogeco and others added 2 commits June 24, 2020 22:53
Ensure that:

1. All stub routines register their arguments in the context, so that
   the values will be available to hook functions.
2. Ensure that the argument names used in stubs match the name in the
   prototype/documentation so the value can be retrieved by name.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 26, 2020
@astrogeco
Copy link
Contributor

CCB - 2020-07-01: APPROVED

@astrogeco astrogeco added CCB:FastTrack CCB-20200701 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jul 1, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate July 2, 2020 19:20
@astrogeco astrogeco merged commit ac29a87 into nasa:integration-candidate Jul 2, 2020
@skliper skliper added this to the 5.1.0 milestone Aug 21, 2020
@jphickey jphickey deleted the fix-526-osal-stub-scrub branch December 3, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrub all OSAL UT stub functions
3 participants