-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #522 - SocketOpen stub should set sock_id #523
Fix #522 - SocketOpen stub should set sock_id #523
Conversation
Missing explicit keywords to autolink with issue. Either use them (Fix #xxx) or link by hand to issue. |
Weird, if you look at the text of the PR, it has an autolink (hover over #522 above). Why it doesn't link it under linked issues is beyond me. :/ |
A simple text reference like "#522" will result in a clickable hyperlink but github does not assume that this PR will fix/close that issue unless you actually say "Fixes #522" or one of the other specific closing keywords. (not "Fix for"). |
CCB-20200624: Approved |
Fix nasa#523, SB Subscription report control on separate MID
Describe the contribution
Fix #522 - OS_SocketOpen() should, on "success", set sock_id and return a status.
Additional context
See OS_SocketOpen() definition in
osal/src/os/inc/osapi-os-net.h
Line 232 in bc73437
Contributor Info - All information REQUIRED for consideration of pull request
[email protected]