Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #449, Rename BSPs to be generic #467

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Rename BSPs that can be used on multiple platforms.
mcp750-vxworks becomes generic-vxworks
pc-linux becomes generic-linux

(pc-rtems stays the same for now)

Testing performed
Build for all supported operating systems (linux, vxworks, rtems) and confirm all unit tests pass and CFE runs normally.

Expected behavior changes
No impact to behavior, but build scripts in external entities need to change the name.

System(s) tested on
Ubuntu 20.04 (native)
RTEMS 4.11 on pc686 / QEMU
VxWorks 6.9 on MCP750

Additional context
See related issue nasa/PSP#162 and PR nasa/PSP#164 which changes the refs to these.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey changed the title Fix 449 generic bsps Fix #449, Rename BSPs to be generic May 15, 2020
@jphickey
Copy link
Contributor Author

Created as a draft due to baseline issues. Only commit for review here is b8cd3d4.

@jphickey jphickey linked an issue May 15, 2020 that may be closed by this pull request
@jphickey jphickey force-pushed the fix-449-generic-bsps branch from b8cd3d4 to 8386f6f Compare May 16, 2020 02:42
@skliper skliper added this to the 5.1.0 milestone May 16, 2020
@astrogeco
Copy link
Contributor

astrogeco commented May 20, 2020

CCB 20200520 - APPROVED, needs to be merged on top of related PRs. Paired with PSP fixes

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label May 26, 2020
@astrogeco astrogeco marked this pull request as ready for review May 27, 2020 14:11
@astrogeco
Copy link
Contributor

astrogeco commented May 27, 2020

@jphickey can I merge this?
Edit: nvm, there's some conflicts after switching base to integration-candidate

@astrogeco astrogeco changed the base branch from master to integration-candidate May 27, 2020 14:12
@astrogeco astrogeco marked this pull request as draft May 27, 2020 14:13
@jphickey
Copy link
Contributor Author

Lets hold off to next cycle, I prefer to rebase to "master" to fix this.

astrogeco and others added 2 commits May 29, 2020 18:46
These adaptor layers can be used on a variety of boards.
Renaming the directory reflects that.

Note - not renaming pc-rtems at this time, as that still
has some non-generic aspects to it.
@jphickey jphickey force-pushed the fix-449-generic-bsps branch from 8386f6f to 11a4899 Compare June 1, 2020 18:32
@jphickey jphickey changed the base branch from integration-candidate to master June 1, 2020 18:33
@jphickey jphickey marked this pull request as ready for review June 1, 2020 18:33
@jphickey
Copy link
Contributor Author

jphickey commented Jun 1, 2020

Rebased to current master, should be good to go now.

@skliper
Copy link
Contributor

skliper commented Jun 2, 2020

@astrogeco This is a project priority, Can it move forward?

@astrogeco astrogeco changed the base branch from master to integration-candidate June 2, 2020 15:34
@astrogeco astrogeco merged commit 50bcbfb into nasa:integration-candidate Jun 2, 2020
@jphickey jphickey deleted the fix-449-generic-bsps branch June 19, 2020 16:13
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Fix nasa#467, #1636 Complete coverage for cfe_es_start.c and cfe_es_syslog.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make BSPs more generic
3 participants