Scrub use of () in return statements

[skliper]

Is your feature request related to a problem? Please describe.
Inconsistent use of (), style. Example below but should fix all.

osal/src/os/portable/os-impl-no-symtab.c

Lines 50 to 60 in ead5723

	return OS_ERR_NOT_IMPLEMENTED;
	}
	/*----------------------------------------------------------------
	* Implementation for no dynamic loader configuration
	*
	* See prototype for argument/return detail
	*-----------------------------------------------------------------*/
	int32 OS_SymbolTableDump_Impl(const char *filename, size_t SizeLimit)
	{
	return (OS_ERR_NOT_IMPLEMENTED);

Describe the solution you'd like
Fix.

Describe alternatives you've considered
Leave as-is (future work)

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review

[thnkslprpt]

Is there consensus on removing the parentheses? @astrogeco @skliper @jphickey

There is ~400 instances of unnecessary parentheses surrounding the return values in the cFS codebase.
For comparison, there is ~4,000 instances of return statements that do not use parentheses for the return value.

From what I can tell no modern C/C++ coding standards require, or even prefer, parentheses around return values (e.g. MISRA, JSF, JPL, ESA etc.).

I'm happy to work on this but wanted to confirm if it's agreed upon first :-)

[skliper]

@dmknutsen - your call. Simple style/consistency thing but could impact many repos. Looks like a simple sed one-liner or similar to fix?

[dmknutsen]

Would be nice to make it consistent + looks pretty straightforward to implement. I would recommend removing the unnecessary parentheses surrounding the return values...simply because there are so many less instances compared to return statements that do not use parentheses.

[thnkslprpt]

OK Thanks Jake/Dan.
I will take care of it.

[thnkslprpt]

For now, I will update only the return statements that return a single value/term like the one Jake linked to above.

I will leave the complex statements as is, even though they are logically unnecessary as well. For example:

osal/src/os/shared/src/osapi-time.c

Lines 206 to 210 in 38559d4

	int32 OS_TimerAdd(osal_id_t *timer_id, const char *timer_name, osal_id_t timebase_ref_id, OS_ArgCallback_t callback_ptr,
	void *callback_arg)
	{
	return (OS_DoTimerAdd(timer_id, timer_name, timebase_ref_id, callback_ptr, callback_arg, 0));
	} /* end OS_TimerAdd */

I know some people prefer parentheses in these cases to make the arithmetical logic easier to break down in their head.

Happy to update the rest in future if it's considered prudent.