Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move set of SO_REUSEADDR to bind/listen #860

Open
skliper opened this issue Mar 10, 2021 · 0 comments
Open

Move set of SO_REUSEADDR to bind/listen #860

skliper opened this issue Mar 10, 2021 · 0 comments
Labels
CFS-38 enhancement

Comments

@skliper
Copy link
Contributor

skliper commented Mar 10, 2021

Is your feature request related to a problem? Please describe.
Opening every socket as SO_REUSEADDR isn't needed:

osal/src/os/portable/os-impl-bsd-sockets.c

Line 151 in ead5723

setsockopt(impl->fd, SOL_SOCKET, SO_REUSEADDR, &os_flags, sizeof(os_flags));

Describe the solution you'd like
Move to more appropriate function

Describe alternatives you've considered
Leave as-is (future work)

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#860 from skliper/fix828-spacecraft-id-hex
0bca6dc 
Fix nasa#828, Spacecraft ID sample set to historical value (0x42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-38 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skliper