Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS_SelectFdZero/OS_SelectFdAdd/OS_SelectFdClear/OS_SelectFdIsSet does not ensure Set is != NULL #390

Closed
CDKnightNASA opened this issue Mar 26, 2020 · 1 comment · Fixed by #409 or #433
Closed

OS_SelectFdZero/OS_SelectFdAdd/OS_SelectFdClear/OS_SelectFdIsSet does not ensure Set is != NULL #390

CDKnightNASA opened this issue Mar 26, 2020 · 1 comment · Fixed by #409 or #433
Assignees
@CDKnightNASA
Labels
bug
Milestone
Bootes

Comments

@CDKnightNASA
Copy link
Contributor

Describe the bug
Users of these API's will cause a seg fault if they call these functions with a null pointer.

To Reproduce
Call OS_SelectFdZero(NULL), etc.

Expected behavior
These API's should return an error code when provided a NULL pointer.

Code snips

int32 OS_SelectFdZero(OS_FdSet *Set)
{  
   memset(Set,0,sizeof(OS_FdSet));
   return OS_SUCCESS;
} /* end OS_SelectFdZero */

System observed on:
Debian 9

Additional context
Add any other context about the problem here.

Reporter Info
[email protected]
@CDKnightNASA CDKnightNASA self-assigned this Mar 26, 2020
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Mar 26, 2020
@CDKnightNASA
fix for nasa#390
b78e4d3
@skliper skliper added this to the 5.1.0 milestone Mar 26, 2020
@CDKnightNASA CDKnightNASA mentioned this issue Mar 26, 2020
Closed
@CDKnightNASA CDKnightNASA added bug CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) and removed enhancement labels Mar 26, 2020
@astrogeco
Copy link
Contributor

CCB 2020-04-01 - Discussed, approved implementation as long as it doesn't change API.

@astrogeco astrogeco linked a pull request Apr 1, 2020 that will close this issue
Fix #390, OS_SelectFd... API's check that Set != NULL #391
Closed
@astrogeco astrogeco added CCB - 20200401 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 1, 2020
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Apr 7, 2020
@CDKnightNASA
fix nasa#377, fix nasa#390, fix nasa#392 - osal select API unit tests…
e7b58e7 
… and fixes
@CDKnightNASA CDKnightNASA mentioned this issue Apr 7, 2020
Merged
astrogeco added a commit that referenced this issue Apr 21, 2020
@astrogeco
Merge pull request #409 from CDKnightNASA/fix-377-select_ut
27dc32f 
Fix #390 and #392, osal select API unit tests and fixes
@astrogeco astrogeco mentioned this issue Apr 27, 2020
Merged
@astrogeco astrogeco linked a pull request Apr 27, 2020 that will close this issue
Integration Candidate: 2020-04-15 #433
Merged
astrogeco pushed a commit that referenced this issue May 1, 2020
@CDKnightNASA
fix #377, fix #390, fix #392 - osal select API unit tests and fixes
e4b3789
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
20191106/13: Merge nasa#387 nasa#390 nasa#391 nasa#393 nasa#395 nasa#400
9aedaab 


Fixes nasa#379, Fixes nasa#380, Fixes nasa#383, Fixes nasa#384,
Fixes nasa#385, Fixes nasa#392
Code reviewed and approved at 20191106 and 20191113 CB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CDKnightNASA CDKnightNASA

Labels
bug
Projects
None yet
Milestone
Bootes
3 participants
@CDKnightNASA @skliper @astrogeco