Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip convar tests if not implemented #1404

Closed
jphickey opened this issue Aug 18, 2023 · 0 comments · Fixed by #1405
Closed

Skip convar tests if not implemented #1404

jphickey opened this issue Aug 18, 2023 · 0 comments · Fixed by #1405
Assignees
@jphickey
Labels
bug
Milestone
Equuleus

Comments

@jphickey
Copy link
Contributor

Describe the bug
If the "no-condvar" implementation is used, all calls will return OS_ERR_NOT_IMPLEMENTED. This is expected/OK. But, the "condvar-test" program does not recognize this, and it reports many failures.

To Reproduce
Run "condvar-test" when using the "no-condvar" implementation

Expected behavior
Should just report that the functionality is not implemented, and skip the tests. Network (and other optional functionality) works this way.

System observed on:
VxWorks 6.9

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Aug 18, 2023
@jphickey jphickey added the bug label Aug 18, 2023
jphickey added a commit to jphickey/osal that referenced this issue Aug 18, 2023
@jphickey
Fix nasa#1404, skip condvar tests if not implemented
5dd1783 
This reports that the functionality is not implemented and reports it as
an MIR result, instead of having most/all of the tests fail.
jphickey added a commit to jphickey/osal that referenced this issue Aug 18, 2023
@jphickey
Fix nasa#1404, skip condvar tests if not implemented
6d1ef70 
This reports that the functionality is not implemented and reports it as
an MIR result, instead of having most/all of the tests fail.
@jphickey jphickey mentioned this issue Aug 18, 2023
Merged
2 tasks
dzbaker added a commit that referenced this issue Aug 18, 2023
@dzbaker
Merge pull request #1405 from jphickey/fix-1404-condvar-test
99e3b40 
Fix #1404, skip condvar tests if not implemented
@chillfig chillfig added this to the Equuleus milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #1404, skip condvar tests if not implemented jphickey/osal
2 participants
@jphickey @chillfig