TOCTOU Bug for chmod

[ArielSAdamsNASA]

Describe the bug
Calling function chmod that uses Filename after a check function. This can cause a time-of-check, time-of-use race condition.

Expected behavior
Use fchmod as seen in OS_FileChmod_Impl.

Code snips

osal/ut_assert/src/uttools.c

Lines 62 to 69 in 42af0f7

	if ((fp = fopen(Filename, "w")))
	{
	if (stat(Filename, &dststat) == 0)
	{
	chmod(Filename, dststat.st_mode & ~(S_IRGRP | S_IWGRP | S_IXGRP | S_IROTH | S_IWOTH | S_IXOTH));
	stat(Filename, &dststat);
	}

osal/ut_assert/src/uttools.c

Lines 111 to 117 in 42af0f7

	if ((fp = fopen(Filename, "w")))
	{
	if (stat(Filename, &dststat) == 0)
	{
	chmod(Filename, dststat.st_mode & ~(S_IRGRP | S_IWGRP | S_IXGRP | S_IROTH | S_IWOTH | S_IXOTH));
	stat(Filename, &dststat);
	}

System observed on:
Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview

Reporter Info
Ariel Adams, ASRC Federal

[skliper]

Could change to fstat and fchmod.