Check Return Value of chmod

[ArielSAdamsNASA]

Describe the bug
Calling chmod(Filename, dststat.st_mode & 0xffffffc0U) without checking return value. This library function may fail and return an error code.

Expected behavior
Check the return value of chmod.

Code snips

osal/ut_assert/src/uttools.c

Line 66 in 42af0f7

chmod(Filename, dststat.st_mode & ~(S_IRGRP | S_IWGRP | S_IXGRP | S_IROTH | S_IWOTH | S_IXOTH));

osal/ut_assert/src/uttools.c

Line 115 in 42af0f7

chmod(Filename, dststat.st_mode & ~(S_IRGRP | S_IWGRP | S_IXGRP | S_IROTH | S_IWOTH | S_IXOTH));

Additional context
From Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview

Possible solution:

if (chmod(Filename, dststat.st_mode & ~(S_IRGRP | S_IWGRP | S_IXGRP | S_IROTH | S_IWOTH | S_IXOTH)) == 0) 
{
      chmod(Filename, dststat.st_mode & ~(S_IRGRP | S_IWGRP | S_IXGRP | S_IROTH | S_IWOTH | S_IXOTH));
      stat(Filename, &dststat);
}

Reporter Info
Ariel Adams, ASRC Federal

[martintc]

I can take this issue.

[skliper]

Recommendation - use fchmod to avoid time of check/time of use warnings. The stat calls aren't needed, so remove. Really the chmod is to avoid another warning about creating a file without limiting permissions. Simply call fchmod and if != 0 printf a message about not being able to limit permissions on the filename.