-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Vue 3 Migration Build #6767
Conversation
- move `v-bind` to first property - remove `.native()` method
…he objectView work
- Replace `.$el` with refs - Use `toRaw()` to unwrap reactive Proxy for comparison
This reverts commit 120e907.
Current Playwright Test Results Summary✅ 13 Passing - ❌ 1 Failing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/19/2023 06:28:15pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: fdfca3a Started: 07/19/2023 06:23:31pm UTC ❌ Failures📄 functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 FailureTest Case Results
Current Playwright Test Results Summary✅ 44 Passing - ❌ 5 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/19/2023 06:28:15pm UTC) ❌ Failures📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 FailureTest Case Results
📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 FailureTest Case Results
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 FailureTest Case Results
📄 functional/plugins/notebook/tags.e2e.spec.js • 1 FailureTest Case Results
📄 functional/notification.e2e.spec.js • 1 FailureTest Case Results
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Gantt Chart Displays all plan events
Retry 1 • Initial Attempt |
10.28% (22)22 / 214 runsfailed over last 7 days |
4.67% (10)10 / 214 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
0% (0)0 / 190 runsfailed over last 7 days |
81.58% (155)155 / 190 runsflaked over last 7 days |
@@ -223,9 +221,13 @@ export default { | |||
this.composition.load(); | |||
this.gridDimensions = [this.$el.offsetWidth, this.$el.scrollHeight]; | |||
|
|||
this.openmct.objects.observe(this.domainObject, 'configuration.items', (items) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the files I indicated on the spreadsheet - good work on this huge change!!
cae4f96
to
62db57b
Compare
* only show marquee for selected item * Revert "only show marquee for selected item" This reverts commit d17af21. * revert change made in #6767 * create framework for displayLayout visual test * WIP create display layout for test * only show marquee for selected * fix selection of object in nested layout * fix grid and code cleanup * add child layouts side by side * code cleanup * externalize setup for reuse in multiple tests * write marquee and grid tests * fix object in layout locator * fix nested layout selector * add aria label to layouts * fix layout locator * add jsdoc for test setup function * make test more efficient * cleanup and linting * update locator * update locators --------- Co-authored-by: John Hill <[email protected]>
Closes #6721
Closes #5713
Describe your changes:
This PR contains the changes necessary to upgrade Open MCT from Vue 2 to the Vue 3 Migration Build. It resolves all incompatibilities between Vue 2 and this migration build. Some of the notable changes include:
new Vue()
component creation patterncreateApp
, but in the context of Open MCT this means dozens of Vue apps being created and destroyed at any given moment. Instead, we have used a community hack for creating individual components.beforeDestroy()
->beforeUnmount()
destroyed()
->unmounted()
deep: true
option on Array listeners is now required to detect Array changesdiv
instead of directly ondocument.body
All Submissions:
Author Checklist
Reviewer Checklist