Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#407] Unit test coverage #433

Merged
merged 51 commits into from
Jan 8, 2025

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Dec 18, 2024

Provide a means to get unit test code coverage values for the sample component (and others once they have functional unit tests as well).

Requires the following merges to be completed and submodules updated prior to closure:

Make sure we squash this one during the merge as well.

Closes #407

@Donnie-Ice
Copy link
Contributor

Is the sc app conflict blocking this?

@jlucas9 jlucas9 changed the title WIP: [nasa/nos3#407] Unit test coverage [nasa/nos3#407] Unit test coverage Jan 6, 2025
Copy link
Contributor

@Donnie-Ice Donnie-Ice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage reports look good!

@jlucas9
Copy link
Contributor Author

jlucas9 commented Jan 7, 2025

Looking to update to newer version of artifact upload in CI to remove warning

Copy link

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With roberts artifact update, I see code coverage pass. I see code coverage artifacts available to download too via zip file.

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked through the outputs. Awesome exhaustive report! Should be quite useful, and good for moving onto the next step (improving coverage across apps). Just looks like we need to do a merge dev or update a couple sub mods before merging this.

@msuder
Copy link
Contributor

msuder commented Jan 7, 2025

Reviewed the pull request. Changed files look reasonable. Reviewed the code coverage reports and they looked reasonable as well. This pull request is approved.

Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage.zip file was available for download and broke down test results when analyzed

@jlucas9 jlucas9 merged commit 3c61261 into dev Jan 8, 2025
2 of 3 checks passed
@jlucas9 jlucas9 deleted the 407-sample-component-unit-test-coverage branch January 8, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants