-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasa/nos3#407] Unit test coverage #433
Conversation
Is the sc app conflict blocking this? |
…nasa/nos3 into 407-sample-component-unit-test-coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage reports look good!
Looking to update to newer version of artifact upload in CI to remove warning |
…nasa/nos3 into 407-sample-component-unit-test-coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With roberts artifact update, I see code coverage pass. I see code coverage artifacts available to download too via zip file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked through the outputs. Awesome exhaustive report! Should be quite useful, and good for moving onto the next step (improving coverage across apps). Just looks like we need to do a merge dev or update a couple sub mods before merging this.
Reviewed the pull request. Changed files look reasonable. Reviewed the code coverage reports and they looked reasonable as well. This pull request is approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage.zip file was available for download and broke down test results when analyzed
Provide a means to get unit test code coverage values for the sample component (and others once they have functional unit tests as well).
Requires the following merges to be completed and submodules updated prior to closure:
Make sure we squash this one during the merge as well.
Closes #407