Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#351] Resolve star tracker quaternion issue #430

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Conversation

@msuder msuder self-assigned this Dec 17, 2024
@jlucas9
Copy link
Contributor

jlucas9 commented Dec 18, 2024

Can confirm that quats match between sim truth and star tracker reported data after enabling it:

image

@jlucas9 jlucas9 changed the title Nos3#351 [nasa/nos3#351] Resolve star tracker quaternion issue Dec 18, 2024
Copy link
Contributor

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that data still being reported successfully from all changed applications.

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-20 105828

Data appears to match, so approved!

Copy link

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star tracker data seems to match, I see the packet viewer between 42 and star tracker data it matches. Approving, but do not merge old build process. Please update submodules to use new build process.

@zlynch2
Copy link

zlynch2 commented Dec 20, 2024

tested new changes to reflect current build process and more current edits to reduce merge conflicts into dev. I see start tracker data is matching after cleaning up branch nos#351

Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replicated steps and confirmed data packets were being transmitted

@jlucas9 jlucas9 merged commit 6de0240 into dev Jan 6, 2025
1 of 2 checks passed
@jlucas9 jlucas9 deleted the nos3#351 branch January 6, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants