Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3946: Bug: Current UI for RevisionList does not indicate to user that a revision has been deleted #1323

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

mandyparson
Copy link
Contributor

@mandyparson mandyparson commented Nov 21, 2024

Overview

What is the feature?

Bug: Current UI for RevisionList does not indicate to user that a revision has been deleted. Created UI for deleted rows as a temp fix.

What is the Solution?

when userId === 'cmr' consider the row deleted.

What areas of the application does this impact?

RevisionList.jsx

Testing

Reproduction steps

  1. Check out the revisions for above Variable. You should see that the row shows that it has been deleted and is unactionable.

Attachments

Screenshot 2024-11-21 at 3 21 40 PM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (c84acf9) to head (73d8232).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1323   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         366      366           
  Lines        5743     5754   +11     
  Branches     1205     1207    +2     
=======================================
+ Hits         5610     5621   +11     
  Misses        132      132           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mandyparson mandyparson merged commit 24b70f4 into main Nov 25, 2024
5 of 7 checks passed
@mandyparson mandyparson deleted the MMT-3946 branch November 25, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants