Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony 1936: Add default job label to harmony-py jobs #100

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

indiejames
Copy link
Contributor

Jira Issue ID

HARMONY-1936

Description

This PR adds a default label of 'harmony-py' to jobs created with this library. It can be disabled by setting the environment variable EXCLUDE_DEFAULT_LABEL to "true".

Local Test Steps

  1. Run the example/basic.ipynb notebook.
  2. Verify that the created job has a 'harmony-py' label
  3. set the EXCLUDE_DEFAULT_LABEL env var to "true"
  4. Run the example notebook again.
  5. Verify that the created job has no label.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

@vinnyinverso
Copy link
Contributor

My only thought is that I wish there were a more centralized place to surface this information to the user, maybe via the readthedocs?

@indiejames
Copy link
Contributor Author

My only thought is that I wish there were a more centralized place to surface this information to the user, maybe via the readthedocs?

Totally agree - was really frustrated by this. Didn't try to update the readthedocs stuff, because it looks that that is totally focused on the API, which is not really what this PR is about.

@indiejames indiejames merged commit c2c1737 into main Jan 23, 2025
11 of 13 checks passed
@indiejames indiejames deleted the harmony-1936 branch January 23, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants