Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #57, Use MSG APIs #58

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Nov 4, 2020

Describe the contribution
Replaces deprecated SB API's with MSG
Fix #57

Testing performed
Built and ran, enabled telemetry, checked noops

Expected behavior changes
None

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
nasa/cFE#777

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 4, 2020
@astrogeco
Copy link
Contributor

CCB 2020-11-04

  • Expected all union declared in the message library with CFE_Msg_msg_t
  • Suggest that all three unions are declared together, @jphickey or @skliper submit a new issue for this

@skliper skliper force-pushed the fix57-use-msg-apis branch from 9f3f7bb to 75ae384 Compare November 4, 2020 18:03
@skliper
Copy link
Contributor Author

skliper commented Nov 4, 2020

75ae384 - Fixed whitespace.

@astrogeco
Copy link
Contributor

CCB 2020-11-04

* Expected all union declared in the message library with CFE_Msg_msg_t

* Suggest that all three unions are declared together, @jphickey or @skliper submit a new issue for this

@jphickey did you open the issue mentioned above?

@astrogeco
Copy link
Contributor

@skliper can you open the issue referenced above?

@skliper
Copy link
Contributor Author

skliper commented Nov 12, 2020

@skliper can you open the issue referenced above?

See nasa/cFE#1009

@astrogeco astrogeco changed the base branch from main to integration-candidate November 12, 2020 14:51
@astrogeco astrogeco merged commit f7d41f6 into nasa:integration-candidate Nov 12, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 12, 2020
@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 12, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 16, 2020
* Add nasa/cFE#984

* Add nasa/cFE#980

* Add nasa/cFE#867

* Add nasa/osal#638 and update cfe due to rebase

* Add nasa/cFE#987

* Add nasa/to_lab#64 and nasa/sample_app#104

* Add nasa/osal#643

* Add nasa/cFE#1000

* Add nasa/ci_lab#58

* Add doxygen fixes for nasa/osal#643

* Add nasa/cFE#1013

* Add nasa/cFE#1011

* Add nasa/ci_lab#61

* Add nasa/sample_app#109

* Bump versions and point to submodules main

Co-authored-by: Joseph Hickey <[email protected]>
@skliper skliper deleted the fix57-use-msg-apis branch February 1, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies on deprecated SB APIs
2 participants