Fix #338, Add MISRA Addons for cppcheck

[ArielSAdamsNASA]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License agreement to [email protected] and copied [email protected].

Describe the contribution
Fixes #338

Testing performed
Tested on forked repo: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1143235812

Expected behavior changes
Runs MISRA rules for bundle, cfe, osal, and psp. Has a job for regular "clean" cppcheck and misra cppcheck.

Additional context
Future work includes:

• Running MISRA rules for the bundle, cfe, osal, and psp.
• Showing errors in the check for errors step

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

[skliper]

I don't think we are allowed to publish MISRA rules, also it looks like the check is just running against misra-test.c. I recommend starting with a local report and doing some analysis there prior to pushing it into CI...

[ArielSAdamsNASA]

I don't think we are allowed to publish MISRA rules, also it looks like the check is just running against misra-test.c. I recommend starting with a local report and doing some analysis there prior to pushing it into CI...

@skliper See new changes. Created a separate job for misra rules. Ran misra analysis against bundle, cfe, osal, and psp instead of misra-test.c.

[skliper]

It's great work, I'm just concerned it may be a little premature to put into CI to run on every push from a project management perspective since we don't really have a plan in place with what to do with the actual results within the repo management process. Maybe make into an action that just gets triggered manually?

[ArielSAdamsNASA]

Updated to trigger workflow manually.

[skliper]

Sorry, I meant trigger the MISRA check as manual. The normal static analysis should still be in the normal push/merge flow since we do need to enforce it.

[ArielSAdamsNASA]

Sorry, I meant trigger the MISRA check as manual. The normal static analysis should still be in the normal push/merge flow since we do need to enforce it.

So have a separate workflow for the misra analysis that runs manually?