Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate: 2020-06-24 #108

Merged
merged 3 commits into from
Jul 26, 2020
Merged

Integration Candidate: 2020-06-24 #108

merged 3 commits into from
Jul 26, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Jul 1, 2020

Describe the contribution
Combines

nasa/cFE#765
nasa/osal#529
nasa/PSP#176
nasa/elf2cfetbl#47
nasa/cFS-GroundSystem#109

Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/108/checks

Expected behavior changes
See submodule PRs.

Minor change to .gitignore so that cfe/cmake/sample_defs inside cfe is currectly tracked in git-aware text editors

System(s) tested on
Ubuntu CI

Additional context
None

Code contibutions
See PRs

Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleir, NASA-GSFC
Jacob Hageman, NASA-GSFC
Joseph Hickey, Vantage Systems, Inc.
Christopher Knight, NASA-ARC
Yasir Khan, Emergent Space Technologies, Inc.
Gerardo E. Cruz-Ortiz, NASA-GSFC

@astrogeco
Copy link
Contributor Author

@skliper @jphickey see the following test failures I haven't merged the fast tracked stuff from yesterday yet.

The following tests FAILED:

	 45 - bin-sem-flush-test (Child aborted)

	 46 - bin-sem-test (Child aborted)

	 47 - bin-sem-timeout-test (Child aborted)

	 48 - count-sem-test (Child aborted)

	 49 - file-api-test (Child aborted)

	 50 - idmap-api-test (Child aborted)

	 51 - mutex-test (Child aborted)

	 52 - osal-core-test (Child aborted)

	 53 - queue-timeout-test (Child aborted)

	 54 - sem-speed-test (Child aborted)

	 55 - symbol-api-test (Child aborted)

	 56 - time-base-api-test (Child aborted)

	 57 - timer-add-api-test (Child aborted)

	 58 - timer-test (Child aborted)

	 59 - osal_core_UT (Failed)

	 60 - osal_loader_UT (Child aborted)

	 61 - osal_filesys_UT (Child aborted)

	 62 - osal_file_UT (Failed)

	 63 - osal_network_UT (Child aborted)

	 64 - osal_timer_UT (Child aborted)

@jphickey
Copy link
Contributor

jphickey commented Jul 2, 2020

These appear to be pretty much all the "functional" tests that run with a real OSAL.
For all of these to fail at once this typically means a permission issue was introduced somehow, notably this is what happens if you e.g. try to run as a normal non-root user without enabling the PERMISSIVE mode, so OS_API_Init() fails, which would cause all of these to fail.

@jphickey
Copy link
Contributor

jphickey commented Jul 2, 2020

Confirmed that this indeed related to the OSAL_CONFIG_DEBUG_PERMISSIVE_MODE setting - the native_osconfig.cmake file isn't getting picked up, so its running in enforcing mode, and permission failing. Possibly related to the build directory structure changes that went into this IC. I will investigate further.

@astrogeco astrogeco marked this pull request as ready for review July 6, 2020 15:05
@astrogeco astrogeco marked this pull request as draft July 6, 2020 15:06
@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2020

LGTM pull request analysis was skipped for 9e3fe42 by astrogeco. Analysis of future commits will happen as normal.

@astrogeco astrogeco marked this pull request as ready for review July 26, 2020 04:17
@astrogeco astrogeco force-pushed the integration-candidate branch from f9370a2 to f41ae80 Compare July 26, 2020 04:31
@astrogeco astrogeco merged commit b1f3e36 into master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants