Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible race condition in documentation deploy workflow #249

Closed
astrogeco opened this issue Apr 22, 2021 · 1 comment · Fixed by #404
Closed

Possible race condition in documentation deploy workflow #249

astrogeco opened this issue Apr 22, 2021 · 1 comment · Fixed by #404

Comments

@astrogeco
Copy link
Contributor

Describe the bug
Since the github actions jobs run in parallel there might be a case of two git commits trying to be pushed "at the same time"

I suggest moving the multiple deploy stages from the separate doc build jobs into a separate deploy job that depends on the successful builds of all docs. Could potentially do something fancy by deploying to separate "local" git branches and then merging them on the deploy branch.

To Reproduce
See https://github.com/nasa/cFS/pull/248/checks?check_run_id=2406018793

Expected behavior
All documentation can be deployed

Additional context
Add any other context about the problem here.

Reporter Info
Full name and company/organization if applicable

@skliper
Copy link
Contributor

skliper commented May 21, 2021

Note #234 made it such that the action wasn't running twice, but there are still two deploys from within the document action. As suggested above, moving the deployment from the two jobs into a deployment job at the end should solve.

ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Dec 20, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Dec 20, 2021
astrogeco added a commit that referenced this issue Jan 21, 2022
…ocumentation-jobs

Fix #249, Combine Deploy Documentation Jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants